libreshop/shop
2
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Brand strings out of nuxt.config + Header + Footer → app.config + runtimeConfig #3

New Issue
Closed
opened 2026-05-04 15:42:15 +02:00 by libretech · 1 comment
libretech commented 2026-05-04 15:42:15 +02:00
Owner
Copy Link
Copy Source

Part of #2

Problem

Brand strings hardcoded in libreshop/shop:

  • nuxt.config.ts:32 — siteUrl: "https://muellerprints-paperwork.com"
  • nuxt.config.ts:58 — page title "MUELLERPRINTS - Handgefertigte Notizbücher aus Stuttgart"
  • components/Header.vue:8,50 — logo text "MUELLERPRINTS. Paperwork", description "Über MUELLERPRINTS"
  • components/Footer.vue:10,83 — footer brand block

Adapters can't override these without forking source. Runtime env can't reach build-time literals.

Acceptance

  • Move brand strings into app.config.ts (layer-mergeable) and runtimeConfig.public (env-overridable)
  • <Header> and <Footer> read brand from useAppConfig() / useRuntimeConfig(), no string literals
  • nuxt.config.ts siteUrl + meta title default to generic "Demo Print Shop"; can be overridden via NUXT_PUBLIC_SITE_URL, NUXT_PUBLIC_BRAND_NAME, NUXT_PUBLIC_BRAND_TAGLINE
  • Page-level useSeoMeta calls (11 pages: about, agb, anfahrt, datenschutz, impressum, kontakt, oeffnungszeiten, versand, zahlung, cart, checkout/*) read brand from config, not literals
  • White-label test: build with default env → no occurrence of "MUELLERPRINTS", "Paperwork", "Stuttgart" in built artifacts
Part of https://git.librete.ch/libreshop/shop/issues/2 ## Problem Brand strings hardcoded in libreshop/shop: - `nuxt.config.ts:32` — `siteUrl: "https://muellerprints-paperwork.com"` - `nuxt.config.ts:58` — page title `"MUELLERPRINTS - Handgefertigte Notizbücher aus Stuttgart"` - `components/Header.vue:8,50` — logo text "MUELLERPRINTS. Paperwork", description "Über MUELLERPRINTS" - `components/Footer.vue:10,83` — footer brand block Adapters can't override these without forking source. Runtime env can't reach build-time literals. ## Acceptance - [ ] Move brand strings into `app.config.ts` (layer-mergeable) and `runtimeConfig.public` (env-overridable) - [ ] `<Header>` and `<Footer>` read brand from `useAppConfig()` / `useRuntimeConfig()`, no string literals - [ ] `nuxt.config.ts` siteUrl + meta title default to generic "Demo Print Shop"; can be overridden via `NUXT_PUBLIC_SITE_URL`, `NUXT_PUBLIC_BRAND_NAME`, `NUXT_PUBLIC_BRAND_TAGLINE` - [ ] Page-level `useSeoMeta` calls (11 pages: about, agb, anfahrt, datenschutz, impressum, kontakt, oeffnungszeiten, versand, zahlung, cart, checkout/*) read brand from config, not literals - [ ] White-label test: build with default env → no occurrence of "MUELLERPRINTS", "Paperwork", "Stuttgart" in built artifacts
libretech commented 2026-09-24 10:45:52 +02:00
Author
Owner
Copy Link
Copy Source

Folded into the single muellerprints.de tracker libretech/mp#50 during the 2026-09-24 cleanup: no activity since 2026-05-04. Reopen when work resumes.

Folded into the single muellerprints.de tracker https://git.librete.ch/libretech/mp/issues/50 during the 2026-09-24 cleanup: no activity since 2026-05-04. Reopen when work resumes.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
libretech (Michael Czechowski) libretech-bot
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: libreshop/shop#3