Test the checkout code; publish images only for releases #5

2026-10-08T22:27:08+02:00

libretech commented

2026-10-08 22:27:08 +02:00

This adds unit tests to the checkout code and changes CI so images are only published for releases. There is no change in behaviour. It is step 2 and step 3 of libretech/mp#71.

Checkout code you can test

The PayPal order request, the pricing, the VAT rates and the log line move into pure modules under src/checkout/ and src/logging/. These need neither Strapi nor the PayPal SDK at runtime.
npm test runs Node's built-in test runner directly on the TypeScript files, with no dependencies.
There are 21 tests:
- 13 pin today's output.
- 8 describe the correct behaviour for the known defects of libretech/mp#67 and are marked todo. The follow-up refactoring turns them into regular tests.

CI

Tests run on Node 22.14.0, the Node of the image, for every pull request, every push to main and every release tag.
The image is built for a pull request (build only) and for a v* tag (built, and published when PUBLISH_ENABLED is set).
main no longer publishes :main and :sha-* images, since nothing pulls them.

Checked before opening:

21 tests, 13 pass, 8 todo, 0 fail, on Node 24 and on Node 22.14 inside the v0.1.1 image (offline).
TypeScript check in the image: 0 errors.
An offline replay of the checkout gives identical results and log lines before and after the change, apart from timestamps.

This adds unit tests to the checkout code and changes CI so images are only published for releases. There is no change in behaviour. It is step 2 and step 3 of https://git.librete.ch/libretech/mp/issues/71. **Checkout code you can test** - The PayPal order request, the pricing, the VAT rates and the log line move into pure modules under `src/checkout/` and `src/logging/`. These need neither Strapi nor the PayPal SDK at runtime. - `npm test` runs Node's built-in test runner directly on the TypeScript files, with no dependencies. - There are 21 tests: - 13 pin today's output. - 8 describe the correct behaviour for the known defects of https://git.librete.ch/libretech/mp/issues/67 and are marked *todo*. The follow-up refactoring turns them into regular tests. **CI** - Tests run on Node 22.14.0, the Node of the image, for every pull request, every push to main and every release tag. - The image is built for a pull request (build only) and for a `v*` tag (built, and published when `PUBLISH_ENABLED` is set). - main no longer publishes `:main` and `:sha-*` images, since nothing pulls them. **Checked before opening:** - 21 tests, 13 pass, 8 todo, 0 fail, on Node 24 and on Node 22.14 inside the `v0.1.1` image (offline). - TypeScript check in the image: 0 errors. - An offline replay of the checkout gives identical results and log lines before and after the change, apart from timestamps.

libretech added 3 commits 2026-10-08 22:27:08 +02:00

refactor(checkout): move VAT rates, pricing and the PayPal order into pure modules 9873c184d6

src/checkout/ holds code without the PayPal SDK or Strapi at runtime, so it can be
unit tested without node_modules:

- vat.ts: vatIncludedDecimal and vatDecimal. config/constants.ts re-exports them
  under the same names and keeps vatDecimalExcluded.
- pricing.ts: calculateTotalProductPrice, unchanged. The product service
  re-exports it, so every importer keeps working.
- paypal-order.ts: the order request createSessionOrThrow builds, in two halves.
  buildPayPalOrderItems (the total guard and the unsent items) still runs
  before the try block, and buildPayPalOrderRequest inside it. Errors and log
  lines stay as they were, for every input. The SDK enums are replaced by their
  string values (CAPTURE, SET_PROVIDED_ADDRESS).

No behaviour change.

Refs libretech/mp#71

refactor(logging): move the console line format into src/logging/format.ts 7fd4aeff17

The printf template of config/logger.ts becomes formatLogLine, with the same
logic, so it can be unit tested without winston.

No behaviour change.

Refs libretech/mp#71

test(checkout): add dependency-free unit tests that pin the checkout defects cbcc54bd75

npm test runs node:test on the TypeScript sources with Node's type stripping
(Node 22.14 in the image, Node 24 locally), with no dependencies.

Node, unlike tsc, does not resolve extensionless relative imports. TypeScript
5.2 cannot emit .ts import extensions. tests/unit/support therefore registers
a small resolve hook that appends ".ts" for imports from .ts files.

- pricing, paypal-order, log-format: characterization tests of the current
  output.
- The known defects of
  libretech/mp#67 are tests of the correct
  behaviour, marked todo: null, two-line and price-null addresses and
  deliveries, a deleted product, the payment surcharge missing from the
  breakdown, and in the log line circular JSON, the Basic credentials of an
  axios error, and an Error rendered as {}.
- That the breakdown adds up to the amount holds today, including for the
  subtotals closest to a half cent, so that test is a regular one.

Refs libretech/mp#71

libretech added 1 commit 2026-10-08 22:29:07 +02:00

ci: run the unit tests, and build images only for pull requests and releases

build / test (pull_request) Successful in 7s

Details

build / build (pull_request) Successful in 6m0s

Details

8bdc2c6b7a

Every push to main published :main and :sha-* images, which nothing pulls.
The libreshop images had grown to 5.8 GB in the registry, on a Gitea host that
is nearly out of space.

- test: npm test for every pull request, every push to main and every release
  tag. It runs in the image's base (Dockerfile FROM, node:22.14.0-alpine), so
  on the runtime's Node, without network and without dependencies. The source
  is piped into the container, because the job container's paths do not exist
  on the Docker host.
- build: after the tests, for a pull request (build only) and for a v* tag
  (build and, with PUBLISH_ENABLED, publish :vX.Y.Z and :latest).

Refs libretech/mp#71

libretech force-pushed refactor/checkout-tests from 707ca854fb to 8bdc2c6b7a

2026-10-08 22:29:07 +02:00

Compare

libretech merged commit 9b0c6af8b7 into main

2026-10-08 22:36:48 +02:00

libretech deleted branch refactor/checkout-tests

2026-10-08 22:36:48 +02:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: libreshop/cms#5